New implementation of low-mc-stats zeroization #76
+112
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am just wanting to confirm that we want the zero-low-mc to be the default option in the wrapper script? |
Yes, I think so. |
kmohrman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new version of the low-mc-stats zeroization. This version only modifies the code in the datacard maker (not in the get yield helper script). This new version does not zeroizes extra systematic uncertainties (in the original implementation, per year systematics were getting zeroized in cases when the individual year's yield was consistent with zero).
Unrelatedly, this PR also updates the hardcoded list of systematic names in the
parse_datacards.pyscript (which is the script we use for dumping the average size of each uncertainty in the datacard) and fixes some issues with the commented print statements in the processor.New refs (corresponding to
analysis_test_08_v03_jan03):4.53651, 2.66225, 5.22267
2.9423, 3.8202, 4.54026